Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary logs, update dependencies' version #37

Conversation

arjenzhou
Copy link
Owner

@arjenzhou arjenzhou commented Sep 18, 2021

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a ISSUE field for the change (usually
    before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should
    address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample in project.
  • Add some description to documents if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #37 (de2f16e) into master (dea86b7) will decrease coverage by 0.35%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
- Coverage     59.30%   58.94%   -0.36%     
- Complexity      162      163       +1     
============================================
  Files            38       38              
  Lines           919      911       -8     
  Branches         61       61              
============================================
- Hits            545      537       -8     
  Misses          332      332              
  Partials         42       42              
Impacted Files Coverage Δ
.../de/xab/porter/transfer/reader/AbstractReader.java 68.42% <ø> (-3.01%) ⬇️
.../xab/porter/transfer/reporter/DefaultReporter.java 100.00% <ø> (ø)
.../de/xab/porter/transfer/writer/AbstractWriter.java 62.06% <ø> (-7.38%) ⬇️
...c/main/java/de/xab/porter/api/task/Properties.java 55.55% <50.00%> (-4.45%) ⬇️
core/src/main/java/de/xab/porter/core/Task.java 89.58% <100.00%> (+0.22%) ⬆️
...de/xab/porter/transfer/jdbc/reader/JDBCReader.java 64.46% <100.00%> (+1.04%) ⬆️
...de/xab/porter/transfer/jdbc/writer/JDBCWriter.java 50.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea86b7...de2f16e. Read the comment docs.

@arjenzhou arjenzhou merged commit e26e476 into master Sep 18, 2021
@arjenzhou arjenzhou deleted the feature/1-add_reader_and_writer_split_which_is_a_m_n_ratio_in_channel branch October 26, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant