Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot helper function #609

Merged
merged 6 commits into from
Dec 10, 2023

Conversation

AlexanderCaichen
Copy link
Contributor

Add helper function to replace often-repeated code in functions found in Plot folder.

@Xiaojieqiu
Copy link
Collaborator

Xiaojieqiu commented Nov 8, 2023

great work, @AlexanderCaichen! is this ready for review?

@AlexanderCaichen
Copy link
Contributor Author

@Xiaojieqiu Sichao still needs to take a look but it should be ready for review.

Copy link
Collaborator

@Sichao25 Sichao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Alex. I left a few comments, mainly about the docstrings.

dynamo/plot/utils.py Outdated Show resolved Hide resolved
dynamo/plot/utils.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (389529e) 22.15% compared to head (ed45e4d) 22.56%.
Report is 14 commits behind head on master.

Files Patch % Lines
dynamo/plot/utils.py 56.00% 11 Missing ⚠️
dynamo/plot/topography.py 0.00% 8 Missing ⚠️
dynamo/plot/preprocess.py 22.22% 7 Missing ⚠️
dynamo/plot/scVectorField.py 0.00% 6 Missing ⚠️
dynamo/plot/time_series.py 20.00% 4 Missing ⚠️
dynamo/plot/vector_calculus.py 0.00% 4 Missing ⚠️
dynamo/plot/heatmaps.py 25.00% 3 Missing ⚠️
dynamo/plot/connectivity.py 0.00% 2 Missing ⚠️
dynamo/plot/dynamics.py 0.00% 2 Missing ⚠️
dynamo/plot/fate.py 50.00% 2 Missing ⚠️
... and 8 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   22.15%   22.56%   +0.40%     
==========================================
  Files         166      166              
  Lines       28058    27540     -518     
==========================================
- Hits         6217     6215       -2     
+ Misses      21841    21325     -516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xiaojieqiu Xiaojieqiu merged commit b074392 into aristoteleo:master Dec 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants