Fix handling of save_show_or_return flags #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heatmaps, and least_action_path Update black version
- least_action_path.lap_min_time - heatmaps.response - heatmaps.causality
- least_action_path.lap_min_time - heatmaps.response - heatmaps.causality - heatmaps.plot_hill_function
…l/dynamo-release into fix_save_show_return
in cell_cycle, connectivity, dynamics
|
This pull request looks good to me. |
Ukyeon
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #326
The following APIs are modified to accept
'save','show', 'return','both', and'all':pl.cell_cycle_scorespl.connectivity_basepl.nneighborspl.phase_portraitspl.dynamicspl.fate_biaspl.fatepl.least_actionpl.bubblepl.nxvizPlotpl.arcPlotpl.hivePlotpl.basic_statspl.show_fractionpl.variance_explainedpl.biplotpl.loadingpl.feature_genespl.exp_by_groupspl.plot_direct_graphpl.scatterspl.show_landscapepl.cell_wise_vectors_3dpl.line_integral_convpl.cell_wise_vectorspl.grid_vectorspl.streamline_plotpl.plot_energypl.state_graphpl.plot_3d_streamtubepl.kinetic_curvespl.kinetic_heatmappl.jacobian_kineticsacceptable value updated from save_fig to savepl.sensitivity_kineticsacceptable value updated from save_fig to savepl.plot_flow_fieldpl.plot_nullclinespl.plot_fixed_points_2dpl.plot_fixed_pointspl.plot_trajpl.plot_separatrixpl.topographypl.jacobianpl.jacobian_heatmappl.sensitivitypl.sensitivity_heatmapThe following APIs now only accept
'save','show','both'and would support'return','all'in future:pl.responsepl.plot_hill_functionpl.causalitypl.comb_logicpl.hessianpl.lap_min_timeThe following APIs rely on previously mentioned APIs and accept
'save','show', 'return','both', and'all'as kwargs:pl.infomappl.leidenpl.louvainpl.pcapl.trimappl.tsnepl.umappl.spacepl.accelerationpl.curlpl.curvaturepl.divergencepl.speed