Add the option to filter data entries according to multiple input values #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drbwa
requested changes
Jan 26, 2025
Comment on lines
177
to
+181
| if job_entry_filter: | ||
| for key, value in job_entry_filter.items(): | ||
| df = df[df[key] != value] | ||
| df = df.drop(key, axis=1) | ||
| for entry in job_entry_filter: | ||
| df = df[~df[entry[constants.JOB_ENTRY_FILTER_NAME_COL]].isin(entry[constants.JOB_ENTRY_FILTER_VALUES_COL])] | ||
| if not entry[constants.JOB_ENTRY_FILTER_KEEP_COL]: | ||
| df = df.drop(entry[constants.JOB_ENTRY_FILTER_NAME_COL], axis=1) |
There was a problem hiding this comment.
If I understand correctly, you can move the drop before the filtering and only
do the filtering when keep is True.
There was a problem hiding this comment.
keep means whether we keep in the data the column according to which we do filtering. If it is False, we still do filtering according to its values, but after filtering we discard the column as it is not needed anymore (e.g., is_valid column to indicate invalid configurations).
drbwa
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.