Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gemfile dirs with spaces in the name #3

Merged
merged 2 commits into from
Mar 14, 2014
Merged

Support Gemfile dirs with spaces in the name #3

merged 2 commits into from
Mar 14, 2014

Conversation

kopischke
Copy link
Contributor

Without this, grep will choke on Gemfile directory paths containing spaces, spewing “no such directory” messages.

@aripollak
Copy link
Owner

Thanks for the patch; would you mind also adding a test for this?

@kopischke
Copy link
Contributor Author

Changing the test to work in a dir with a space in its name should do it. See second commit.

@aripollak
Copy link
Owner

I think it would still be nice if there were an explicit test for it, so it doesn't accidentally break later.

@kopischke
Copy link
Contributor Author

You may be right, but I won’t be writing it, as learning your test framework would take considerably more time than I have available for this (sorry if that sounds harsh, but that’s how it is). Considering how trivial the code change is, that it cannot have negative side effects (as the behaviour of quoting file paths in the shell is unambiguous) and that it fixes a show stopper, maybe merge the patch and just put extended test coverage on your todo list for the project?

aripollak added a commit that referenced this pull request Mar 14, 2014
Support Gemfile dirs with spaces in the name
@aripollak aripollak merged commit 32bd1a6 into aripollak:master Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants