Updating to Ng 14 #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it to avoid throwing ExpressionChangedAfterItHasBeenCheckedError. More info https://angular.io/errors/NG0100.
chrux
changed the title
|
I forgot to migrate to eslint, will do the change first |
Instead of tslint which is deprecated.
Instead of tslint which is deprecated.
chrux
changed the title
chrux
changed the title
|
Hey @chrux ! It would be great if you could do the upgrade as I don't have time now. I see you closed your PRs. Any issues with that? |
|
Hello, thanks for replying so quickly and sorry I couldn't answer before, this the PR with the changes, pls let me know what you think, #81, also I had to revert Ng 14 as this plugins for cordova was causing some issues |
|
Hey @chrux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge or review #79 first