Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log result of HTTP requests & artifacts load/saves. Closes #8257 #8394

Merged
merged 4 commits into from
Apr 18, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 13, 2022

Signed-off-by: Alex Collins [email protected]

Closes #8257

This PR:

  • Improves out ability to debug issues related to artifacts.
  • Makes it impossible for bugs in the code to allow authentication problems to be un-logged.

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as ready for review April 14, 2022 14:48
@alexec alexec enabled auto-merge (squash) April 14, 2022 14:48
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know when you have addressed your own comments and ready to merge.

Signed-off-by: Alex Collins <[email protected]>
@alexec alexec marked this pull request as draft April 18, 2022 17:34
auto-merge was automatically disabled April 18, 2022 17:34

Pull request was converted to draft

@alexec alexec marked this pull request as ready for review April 18, 2022 18:43
@alexec alexec enabled auto-merge (squash) April 18, 2022 18:43
@alexec
Copy link
Contributor Author

alexec commented Apr 18, 2022

@terrytangyuan ready for review.

@alexec alexec merged commit 5845efb into master Apr 18, 2022
@alexec alexec deleted the dev-log branch April 18, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.3: Retrieving pod artifacts using Web UI from S3 is slow
2 participants