Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.41.1 #7658

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Jan 27, 2022

Signed-off-by: William Van Hevelingen [email protected]

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

@blkperl
Copy link
Contributor Author

blkperl commented Jan 27, 2022

This should unblock dependabot from updating viper in #7645

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @alexec Please help double check as well.

@blkperl
Copy link
Contributor Author

blkperl commented Jan 27, 2022

@terrytangyuan any idea on how to fix the failing e2e test or what could be causing it?

@terrytangyuan
Copy link
Member

@terrytangyuan any idea on how to fix the failing e2e test?

Perhaps the new version changed the default content type? I’d check the release notes to see if anything else needs to be updated.

@alexec
Copy link
Contributor

alexec commented Jan 27, 2022

Look like it broke the test, that needs fixing.

alexec
alexec previously requested changes Jan 27, 2022
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should change dependant to only update the patch version, too many minor versions seem to be breaking.

@blkperl
Copy link
Contributor Author

blkperl commented Jan 27, 2022

@terrytangyuan @alexec I checked the grpc release notes and nothing stood out to me. I'm not familiar with grpc so I'm not quite sure what to try next.

@alexec re: dependabot only updating patch version I think there will be edge cases like grpc here but most of the time it should work if they don't break backwards compatibility on a minor release. The viper pr only broke because it pulled in the new grpc version because it was an indirect dependency.

I'm also happy to submit prs to update the grpc minor version one at a time until we find which release causes the test failure.

Signed-off-by: William Van Hevelingen <[email protected]>
@blkperl blkperl changed the title chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.44.0 chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.40.0 Jan 27, 2022
Signed-off-by: William Van Hevelingen <[email protected]>
@blkperl blkperl changed the title chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.40.0 chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.42.0 Jan 28, 2022
Signed-off-by: William Van Hevelingen <[email protected]>
@blkperl blkperl changed the title chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.42.0 chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.41.1 Jan 28, 2022
@blkperl
Copy link
Contributor Author

blkperl commented Jan 28, 2022

I asked upstream about 1.42.0 grpc/grpc-go#5175

@blkperl
Copy link
Contributor Author

blkperl commented Jan 28, 2022

@alexec We can merge this in the meantime as it passes on grpc 1.41.1.

@terrytangyuan terrytangyuan merged commit 4664aea into argoproj:master Jan 28, 2022
@terrytangyuan
Copy link
Member

Thank you!

@blkperl blkperl deleted the bump_grpc branch February 1, 2022 17:06
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants