-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump google.golang.org/grpc from v1.38.0 to v1.41.1 #7658
Conversation
Signed-off-by: William Van Hevelingen <[email protected]>
This should unblock dependabot from updating viper in #7645 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @alexec Please help double check as well.
@terrytangyuan any idea on how to fix the failing e2e test or what could be causing it? |
Perhaps the new version changed the default content type? I’d check the release notes to see if anything else needs to be updated. |
Look like it broke the test, that needs fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should change dependant to only update the patch version, too many minor versions seem to be breaking.
@terrytangyuan @alexec I checked the grpc release notes and nothing stood out to me. I'm not familiar with grpc so I'm not quite sure what to try next. @alexec re: dependabot only updating patch version I think there will be edge cases like grpc here but most of the time it should work if they don't break backwards compatibility on a minor release. The viper pr only broke because it pulled in the new grpc version because it was an indirect dependency. I'm also happy to submit prs to update the grpc minor version one at a time until we find which release causes the test failure. |
Signed-off-by: William Van Hevelingen <[email protected]>
Signed-off-by: William Van Hevelingen <[email protected]>
Signed-off-by: William Van Hevelingen <[email protected]>
I asked upstream about 1.42.0 grpc/grpc-go#5175 |
@alexec We can merge this in the meantime as it passes on grpc 1.41.1. |
Thank you! |
Signed-off-by: William Van Hevelingen [email protected]
Don't bother creating a PR until you've done this:
make pre-commit -B
to fix codegen, lint, and commit message problems.Create your PR as a draft.
does not need to pass.
Tips: