feat: add local variable pod.retryAttempt. Fixes #2808, Fixes #2898.

[seddonm1]

• add pod.retryAttempt that reports the retry attempt number starting at 0 for first attempt and increasing by 1 each attempt.
• only executes on nodes with retryStrategy defined.
• updated the examples/retry-with-steps.yaml to demonstrate usage.
• updated the docs/variables.md to describe variable.

Fixes #2808 and Fixes #2898 for enhancement request.

Checklist:

• Either (a) I've created an [enhancement proposal]
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed the CLA.
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md. -- N/A

[simster7]

Great start! Some comments to fix

[simster7]

Looking better!

[simster7]

This LGTM as is, but I want to confirm with the rest of the team that retryAttempt is the name we want for this (as opposed to something like retryNumber or attemptNumber or the like) before approving and merging.

[seddonm1]

Great. Thanks Simon. Naming is half the battle.

[simster7]

Hey @seddonm1, sorry for the delay. We decided to name this flag {{retries}}. The idea is that when you run your first attempt, it is technically attempt number 1, but {{retryAttempts}} would say 0. This might be a bit of a misnomer. {{retries}} however indicates that there have been 0 retries, which is a tad more accurate.

Can you update the naming and resolve the conflicts please?

[seddonm1]

this code is now up to date and has the variable named retries.

[simster7]

@seddonm1 Seems like there was a Git issue when you rebased/merged with master. You can see that this PR now changes 150+ files, which is not desired.

Can you solve this and make sure that it only contains your desired changes?

[seddonm1]

@simster7 Sorry. not sure what happened with my client. fixed.