fix: make controllers tolerant to spec marshalling errors #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #389, #517
Uses a new, specialized "tolerant" dynamic informer which tolerates malformed objects that cannot unmarshal properly, preventing the issue where a unmarshallable object renders the entire controller unusable. When an object is discovered to be malformed, the informer will return a best effort version of the object via json unmarshalling (dropping all fields which could not be marshalled properly). This allows the controller to proceed as if the mistake was never made.
A consequence of this change is that the malformed field is silently dropped. But this is at least better behavior than stopping the controller.