Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for rootService within ALB traffic routing #634

Merged
merged 4 commits into from
Aug 15, 2020

Conversation

dthomson25
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #634 into master will decrease coverage by 0.03%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   85.29%   85.25%   -0.04%     
==========================================
  Files          88       88              
  Lines        8642     8654      +12     
==========================================
+ Hits         7371     7378       +7     
- Misses        899      903       +4     
- Partials      372      373       +1     
Impacted Files Coverage Δ
pkg/apis/rollouts/validation/validation.go 90.22% <0.00%> (-1.38%) ⬇️
.../apis/rollouts/validation/validation_references.go 77.14% <57.14%> (-1.86%) ⬇️
rollout/trafficrouting/alb/alb.go 97.40% <100.00%> (+0.06%) ⬆️
utils/ingress/ingress.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806ca6b...1b6d235. Read the comment docs.

@dthomson25 dthomson25 changed the title Add support for rootService within ALB traffic routing feat: Add support for rootService within ALB traffic routing Aug 14, 2020
Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit e067432 into argoproj:master Aug 15, 2020
@dthomson25 dthomson25 deleted the alb-root branch August 17, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants