Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix various panics #603

Merged
merged 2 commits into from
Aug 3, 2020
Merged

fix: Fix various panics #603

merged 2 commits into from
Aug 3, 2020

Conversation

dthomson25
Copy link
Member

@dthomson25 dthomson25 commented Jul 31, 2020

Fixes panics in:

  • metrics provider
  • Ingress controller
  • Restarting Rollouts

@dthomson25 dthomson25 changed the title Fix panic in rollout restart fix: Fix panic in rollout restart Jul 31, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #603 into master will decrease coverage by 0.08%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
- Coverage   85.80%   85.71%   -0.09%     
==========================================
  Files          87       87              
  Lines        8297     8380      +83     
==========================================
+ Hits         7119     7183      +64     
- Misses        844      859      +15     
- Partials      334      338       +4     
Impacted Files Coverage Δ
utils/kubeclientmetrics/metric.go 89.20% <20.00%> (-2.65%) ⬇️
controller/metrics/client.go 100.00% <100.00%> (ø)
ingress/ingress.go 59.49% <100.00%> (ø)
rollout/restart.go 95.78% <100.00%> (+0.04%) ⬆️
utils/analysis/helpers.go 90.27% <0.00%> (-4.85%) ⬇️
utils/analysis/filter.go 97.72% <0.00%> (-2.28%) ⬇️
rollout/pause.go 99.14% <0.00%> (+0.03%) ⬆️
rollout/canary.go 85.93% <0.00%> (+0.05%) ⬆️
rollout/sync.go 74.75% <0.00%> (+0.06%) ⬆️
rollout/context.go 98.56% <0.00%> (+0.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46086a4...f05223e. Read the comment docs.

@dthomson25 dthomson25 merged commit 83e600e into argoproj:master Aug 3, 2020
@dthomson25 dthomson25 deleted the fix-panic branch August 3, 2020 16:34
@dthomson25 dthomson25 changed the title fix: Fix panic in rollout restart fix: Fix various panics Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants