Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the currentStepIndex to max after bg to canary #558

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

dthomson25
Copy link
Member

closes #555.

@jessesuen do you know why we defaulted checkStepHashChange to return false if the currentStepHash is empty?

@dthomson25 dthomson25 changed the title Set the currentStepIndex to max after bg to canary fix: Set the currentStepIndex to max after bg to canary Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #558 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   85.92%   85.93%   +0.01%     
==========================================
  Files          86       86              
  Lines        8136     8136              
==========================================
+ Hits         6991     6992       +1     
+ Misses        819      818       -1     
  Partials      326      326              
Impacted Files Coverage Δ
utils/replicaset/replicaset.go 90.03% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cc2f0...d4bb510. Read the comment docs.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if someone does: Canary -> BlueGreen -> Canary?

Do we null out the status.canary fields when moving away from canary? Otherwise we might carry over defunct stephash / stepindex information and still have this problem

utils/replicaset/replicaset.go Outdated Show resolved Hide resolved
@dthomson25 dthomson25 force-pushed the fix-bg-to-canry-strat branch from 27e7984 to d4bb510 Compare June 26, 2020 20:55
@dthomson25
Copy link
Member Author

The controller nulled all the canary status field when the user switches the Rollout from canary back to bluegreen

@dthomson25 dthomson25 merged commit 656918f into argoproj:master Jun 26, 2020
@dthomson25 dthomson25 deleted the fix-bg-to-canry-strat branch August 14, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollout stuck after switching from bluegreen to Canary
2 participants