Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SMI TrafficSplit Support for Canary #520

Merged
merged 14 commits into from
Jun 16, 2020

Conversation

khhirani
Copy link
Contributor

Closes #359

@khhirani khhirani changed the title SMI TrafficSplit Support for Canary feat: SMI TrafficSplit Support for Canary May 27, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #520 into master will increase coverage by 0.21%.
The diff coverage is 95.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   85.66%   85.87%   +0.21%     
==========================================
  Files          85       86       +1     
  Lines        7923     8123     +200     
==========================================
+ Hits         6787     6976     +189     
- Misses        814      820       +6     
- Partials      322      327       +5     
Impacted Files Coverage Δ
rollout/trafficrouting.go 93.10% <88.23%> (-2.73%) ⬇️
rollout/trafficrouting/smi/smi.go 95.21% <95.21%> (ø)
rollout/controller.go 73.33% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5248136...b0d6b27. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great so far! There are some minor things that we need to work through but all in all good work!

cmd/rollouts-controller/main.go Outdated Show resolved Hide resolved
rollout/controller.go Outdated Show resolved Hide resolved
rollout/trafficrouting.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Show resolved Hide resolved
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of comments but I think it's almost there!

rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments but otherwise LGTM! Great work!

rollout/trafficrouting_test.go Outdated Show resolved Hide resolved
rollout/trafficrouting_test.go Outdated Show resolved Hide resolved
@khhirani khhirani merged commit 0b074c7 into argoproj:master Jun 16, 2020
@khhirani khhirani deleted the canary-smi-traffic-split branch June 16, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SMI (Service Mesh Interface) TrafficSplit Support
2 participants