Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove hash selector after switching from bg to canary #515

Merged
merged 1 commit into from
May 28, 2020

Conversation

dthomson25
Copy link
Member

close #506

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #515 into master will increase coverage by 0.04%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   85.63%   85.68%   +0.04%     
==========================================
  Files          85       85              
  Lines        7901     7934      +33     
==========================================
+ Hits         6766     6798      +32     
- Misses        813      814       +1     
  Partials      322      322              
Impacted Files Coverage Δ
service/service.go 64.70% <91.66%> (+1.74%) ⬆️
rollout/controller.go 73.33% <100.00%> (+0.29%) ⬆️
utils/service/service.go 100.00% <100.00%> (ø)
utils/evaluate/evaluate.go 96.15% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddf8e03...cdb5311. Read the comment docs.

@dthomson25 dthomson25 merged commit 9d88dad into argoproj:master May 28, 2020
@dthomson25 dthomson25 deleted the switch-bg-to-canary branch August 14, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller does not remove pod hash from Rollout switched from bg to canary
2 participants