Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify arg verification to check ValueFrom #500

Merged
merged 3 commits into from
May 8, 2020
Merged

fix: Modify arg verification to check ValueFrom #500

merged 3 commits into from
May 8, 2020

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented May 8, 2020

Closes #499

@codecov
Copy link

codecov bot commented May 8, 2020 •
edited
Loading

Codecov Report

Merging #500 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   85.63%   85.73%   +0.10%     
==========================================
  Files          85       85              
  Lines        7906     7874      -32     
==========================================
- Hits         6770     6751      -19     
+ Misses        814      802      -12     
+ Partials      322      321       -1
Impacted Files Coverage Δ
utils/analysis/helpers.go 95.65% <100.00%> (+0.07%) ⬆️
service/service.go 63.04% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8861cff...5a47843. Read the comment docs.

@khhirani khhirani requested a review from dthomson25 May 8, 2020 00:42
dthomson25
dthomson25 approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khhirani khhirani merged commit f90fc77 into argoproj:master May 8, 2020
@khhirani khhirani deleted the analysisrun-verify-args branch May 8, 2020 20:55
khhirani added a commit that referenced this pull request Jun 4, 2020
@khhirani
fix: Modify arg verification to check ValueFrom (#500)
4770fb5 
* Modify MergeArgs to verify args using ValueFrom
@nextrevision nextrevision mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthomson25 dthomson25 dthomson25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller does not correctly verify Arguments that use ValueFrom
2 participants
@khhirani @dthomson25