Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure ALB action has weight 0 marshalled correctly #493

Merged
merged 1 commit into from
May 5, 2020

Conversation

dthomson25
Copy link
Member

closes #491

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #493 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files          85       85           
  Lines        7920     7920           
=======================================
  Hits         6784     6784           
  Misses        814      814           
  Partials      322      322           
Impacted Files Coverage Δ
utils/ingress/ingress.go 100.00% <ø> (ø)
ingress/alb.go 96.55% <100.00%> (ø)
rollout/trafficrouting/alb/alb.go 97.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9417a99...282d450. Read the comment docs.

@dthomson25 dthomson25 merged commit e18bb35 into argoproj:master May 5, 2020
@dthomson25 dthomson25 deleted the fix-alb-marshal branch May 5, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller omits ALB Weight at steady state
2 participants