Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Download go deps explicitly in Dockerfile #464

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

duboisf
Copy link
Contributor

@duboisf duboisf commented Apr 8, 2020

Copy only go.mod and go.sum and download the dependencies before running the build. This way if the source files change but not the dependencies, the docker build will leverage layer caching and not re-download the go dependencies.

Copy only go.mod and go.sum and download the dependencies _before_
running the build. This way if the source files change but _not_ the
dependencies, the docker build will leverage layer caching and not
re-download the go dependencies.
@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #464 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files          80       80           
  Lines        7597     7597           
=======================================
  Hits         6472     6472           
  Misses        808      808           
  Partials      317      317           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04dcfe...161b034. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit 8db25b7 into argoproj:master Apr 8, 2020
@duboisf duboisf deleted the download-go-deps branch April 9, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants