chore: set kubectl flags on root command #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset compliments argoproj#454 by making the cli flags more readable in documentation and usage help. The options AddKubectlFlags is only applied to the the root argo rollouts command and has been removed from all the child commands. The result of this from a documentation perspective is options are now split between options specific to the command and options inherited from parent. One side effect of this is tests that use inherited args need to call `o.AddKubectlFlags(cmd)` explicitly.
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 85.17% 85.14% -0.03%
==========================================
Files 80 80
Lines 7539 7525 -14
==========================================
- Hits 6421 6407 -14
Misses 804 804
Partials 314 314
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset compliments #454 by making the cli flags more
readable in documentation and usage help.
The options AddKubectlFlags is only applied to the the root
argo rollouts command and has been removed from all the child
commands. The result of this from a documentation perspective
is options are now split between options specific to the command
and options inherited from parent.
One side effect of this is tests that use inherited args need to call
o.AddKubectlFlags(cmd)explicitly.