Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use managed-by annotation #448

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

dthomson25
Copy link
Member

Closes #443 by introducing a new annotation called argo-rollouts.argoproj.io/managed-by-rollouts that indicates a Service is managed by a Rollout.

@dthomson25 dthomson25 changed the title Use managed-by annotation feat: Use managed-by annotation Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #448 into master will decrease coverage by 0.19%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   85.20%   85.01%   -0.20%     
==========================================
  Files          80       80              
  Lines        7478     7415      -63     
==========================================
- Hits         6372     6304      -68     
- Misses        798      799       +1     
- Partials      308      312       +4     
Impacted Files Coverage Δ
utils/conditions/conditions.go 88.95% <ø> (ø)
service/service.go 62.96% <84.61%> (+4.39%) ⬆️
rollout/service.go 87.38% <87.50%> (-0.25%) ⬇️
utils/service/service.go 100.00% <100.00%> (ø)
pkg/kubectl-argo-rollouts/info/replicaset_info.go 78.94% <0.00%> (-5.50%) ⬇️
experiments/experiment.go 93.14% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a76fca...8e106c0. Read the comment docs.

@dthomson25 dthomson25 force-pushed the add-managed-by-to-svc branch from 6913b41 to d1e78d7 Compare March 26, 2020 15:21
@dthomson25 dthomson25 force-pushed the add-managed-by-to-svc branch from d1e78d7 to 8e106c0 Compare April 2, 2020 21:03
@dthomson25 dthomson25 merged commit ebfd2f5 into argoproj:master Apr 2, 2020
@dthomson25 dthomson25 deleted the add-managed-by-to-svc branch April 2, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services are modified by controller running with different instance ID
2 participants