Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix wrong comment about the formula of calculating the replica number #447

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

nghialv
Copy link
Contributor

@nghialv nghialv commented Mar 23, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files          77       77           
  Lines        7241     7241           
=======================================
  Hits         6138     6138           
  Misses        798      798           
  Partials      305      305
Impacted Files Coverage Δ
utils/replicaset/canary.go 80.39% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb7e9c...925cdcc. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit f60a0f6 into argoproj:master Mar 24, 2020
@nghialv nghialv deleted the fix-replica-formula branch March 25, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants