Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Role/ClusterRole for Ingress access #439

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

moensch
Copy link
Contributor

@moensch moensch commented Mar 12, 2020

And ran make manifests to update consolidated manifests.

moensch added 2 commits March 11, 2020 18:19
And ran `make manifests` to update consolidated manifests.
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files          77       77           
  Lines        7201     7201           
=======================================
  Hits         6098     6098           
  Misses        798      798           
  Partials      305      305

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1240d1b...f72c10f. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moensch
Copy link
Contributor Author

moensch commented Mar 12, 2020

Tested the changes in my local setup and they're good to go.

@dthomson25 dthomson25 merged commit cfff733 into argoproj:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants