-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement: Surface failure reasons for Rollouts/AnalysisRuns #434
improvement: Surface failure reasons for Rollouts/AnalysisRuns #434
Conversation
… of failed/error/inconclusive metrics
…ssessing phase of Metric and creating message for logs and status. Add tests for assessRunStatus and assessMetricFailureInconclusiveOrError
…to ro-analysis-surface-fail-msg
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 85.17% 85.17%
=======================================
Files 77 77
Lines 7456 7456
=======================================
Hits 6351 6351
Misses 797 797
Partials 308 308 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the functionality is great, and I have a couple of style comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some small style comments. Please take a look.
…to ro-analysis-surface-fail-msg
Resolves #404