Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Surface failure reasons for Rollouts/AnalysisRuns #434

Merged
merged 10 commits into from
Mar 12, 2020

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented Mar 9, 2020

Resolves #404

khhirani added 4 commits March 5, 2020 19:29
…ssessing phase of Metric and creating message for logs and status. Add tests for assessRunStatus and assessMetricFailureInconclusiveOrError
@khhirani khhirani changed the title Surface failure reasons for Rollouts/AnalysisRuns improvement: Surface failure reasons for Rollouts/AnalysisRuns Mar 9, 2020
@khhirani khhirani requested a review from dthomson25 March 9, 2020 18:25
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files          77       77           
  Lines        7456     7456           
=======================================
  Hits         6351     6351           
  Misses        797      797           
  Partials      308      308

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfff733...21b0580. Read the comment docs.

Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the functionality is great, and I have a couple of style comments

analysis/analysis.go Outdated Show resolved Hide resolved
analysis/analysis.go Outdated Show resolved Hide resolved
analysis/analysis.go Show resolved Hide resolved
analysis/analysis.go Outdated Show resolved Hide resolved
analysis/analysis_test.go Outdated Show resolved Hide resolved
analysis/analysis_test.go Outdated Show resolved Hide resolved
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some small style comments. Please take a look.

analysis/analysis.go Outdated Show resolved Hide resolved
utils/defaults/defaults_test.go Outdated Show resolved Hide resolved
utils/defaults/defaults_test.go Outdated Show resolved Hide resolved
utils/defaults/defaults_test.go Show resolved Hide resolved
analysis/analysis_test.go Outdated Show resolved Hide resolved
analysis/analysis_test.go Outdated Show resolved Hide resolved
@khhirani khhirani merged commit 8d63848 into argoproj:master Mar 12, 2020
@khhirani khhirani deleted the ro-analysis-surface-fail-msg branch March 12, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis failure / rollout aborted reason should be surfaced
2 participants