Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollout transformer for pod affinity. add new v0.7 name references and testing #399

Merged
merged 6 commits into from
Feb 7, 2020

Conversation

jessesuen
Copy link
Member

Resolves #395 and #364

@jessesuen jessesuen requested a review from dthomson25 February 7, 2020 01:45
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25
Copy link
Member

Looks like the CI is failing because the CI container doesn't have kustomize installed:

./test/kustomize/test.sh: line 7: kustomize: command not found

@dthomson25 dthomson25 force-pushed the kustomize-transformers branch from 6b34083 to ba1f259 Compare February 7, 2020 23:11
@dthomson25 dthomson25 merged commit 4bf6fa3 into argoproj:master Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #399 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          70       70           
  Lines        6582     6582           
=======================================
  Hits         5531     5531           
  Misses        762      762           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beeeb56...ba1f259. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomize label configuration for rollouts has wrong api group
2 participants