Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add autogenerated sites/ to gitignore #398

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

dthomson25
Copy link
Member

When we deploy the documentation to https://argoproj.github.io/argo-rollouts/, the mkdocs command creates a directory called site/. Since this directory is auto-generated from the docs folder, there is no reason for us to keep the code in Git.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   84.03%   84.03%           
=======================================
  Files          70       70           
  Lines        6582     6582           
=======================================
  Hits         5531     5531           
  Misses        762      762           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beeeb56...40abec7. Read the comment docs.

Copy link
Contributor

@khhirani khhirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dthomson25 dthomson25 merged commit 737d9cd into argoproj:master Feb 6, 2020
@dthomson25 dthomson25 deleted the modify-gitignore branch February 6, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants