Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links #3962

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

pierrebailletsonos
Copy link
Contributor

@pierrebailletsonos pierrebailletsonos commented Nov 21, 2024

  • Fix external reference urls.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

- Fix external reference urls.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (5f59344) to head (16232cc).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3962      +/-   ##
==========================================
- Coverage   82.69%   82.68%   -0.02%     
==========================================
  Files         163      163              
  Lines       22895    22895              
==========================================
- Hits        18934    18930       -4     
- Misses       3087     3090       +3     
- Partials      874      875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 17m 8s ⏱️
113 tests 103 ✅  7 💤  3 ❌
464 runs  425 ✅ 28 💤 11 ❌

For more details on these failures, see this check.

Results for commit 16232cc.

Copy link
Contributor

Published Unit Test Results

2 280 tests   2 280 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 16232cc.

@zachaller zachaller merged commit a4d50d8 into argoproj:master Dec 6, 2024
25 checks passed
Rizwana777 pushed a commit to Rizwana777/argo-rollouts that referenced this pull request Dec 12, 2024
Update notifications.md

- Fix external reference urls.
@lens0021
Copy link

lens0021 commented Jan 9, 2025

Sorry for commenting a closed PR. But does anyone have a plan to backport this to the stable documentations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants