Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop rollout from entering degraded state during blueGreen pause. Fixes #3843 #3845

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

miles-w-3
Copy link
Contributor

@miles-w-3 miles-w-3 commented Sep 23, 2024

Closes #3843

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@miles-w-3 miles-w-3 force-pushed the bugfix/degraded-blue-green branch from bb1b1b7 to 2acac37 Compare September 23, 2024 15:49
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.88%. Comparing base (ff93786) to head (0d8b998).
Report is 74 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3845      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.02%     
==========================================
  Files         163      163              
  Lines       18560    18564       +4     
==========================================
+ Hits        15565    15573       +8     
+ Misses       2121     2119       -2     
+ Partials      874      872       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 24m 28s ⏱️
113 tests 101 ✅  7 💤  5 ❌
468 runs  424 ✅ 28 💤 16 ❌

For more details on these failures, see this check.

Results for commit 2acac37.

Copy link
Contributor

Published Unit Test Results

2 275 tests   2 275 ✅  2m 58s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit 2acac37.

@zachaller zachaller force-pushed the bugfix/degraded-blue-green branch from 2acac37 to 0d8b998 Compare September 27, 2024 14:03
Copy link

@zachaller zachaller enabled auto-merge (squash) September 27, 2024 14:11
@zachaller zachaller merged commit 4e44913 into argoproj:master Sep 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollouts cycle into degraded state during blue-green pause
2 participants