Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update web metrics section #381

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

cronik
Copy link
Contributor

@cronik cronik commented Jan 24, 2020

  • update web metrics example
  • fix toc for analysis page by correcting CRD heading
  • include command to view docs locally using docker

* update web metrics example
* fix toc for analysis page by correcting CRD heading
* include command to view docs locally using docker
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +120 to +124
If you don't want to setup mkDocs locally, the following docker command should suffice:

```shell
docker run --rm -it -p 8000:8000 -v ${PWD}:/docs squidfunk/mkdocs-material
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dthomson25 dthomson25 merged commit 1a6273e into argoproj:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants