Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: copy omission in rollout docs #3690

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

mathisto
Copy link
Contributor

@mathisto mathisto commented Jul 1, 2024

Looks like this sentence is incomplete. Might I suggest this change to make it read more naturally?

Looks like this sentence is incomplete. Might I suggest this change to make it read more naturally?
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (4f1edbe) to head (c868676).
Report is 89 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3690   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files         156      156           
  Lines       17964    17965    +1     
=======================================
+ Hits        14420    14421    +1     
  Misses       2631     2631           
  Partials      913      913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Go Published Test Results

2 164 tests   2 164 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit c868676.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

E2E Tests Published Test Results

  4 files    4 suites   4h 27m 55s ⏱️
112 tests  59 ✅  6 💤 47 ❌
322 runs  208 ✅ 20 💤 94 ❌

For more details on these failures, see this check.

Results for commit c868676.

♻️ This comment has been updated with latest results.

@zachaller zachaller changed the title Fix copy omission in rollout docs chore(docs): copy omission in rollout docs Jul 2, 2024
@zachaller zachaller changed the title chore(docs): copy omission in rollout docs chore: copy omission in rollout docs Jul 10, 2024
@zachaller zachaller changed the title chore: copy omission in rollout docs docs: copy omission in rollout docs Jul 10, 2024
@zachaller zachaller merged commit 764f530 into argoproj:master Jul 10, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants