fix(analysis): Take RollbackWindow into account when Reconciling Analysis Runs. Fixes #3669 #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Psukhe
changed the title
Go Published Test Results2 164 tests 2 164 ✅ 2m 54s ⏱️ Results for commit 2ed5b66. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3670 +/- ##
==========================================
- Coverage 80.27% 80.25% -0.02%
==========================================
Files 156 156
Lines 17964 17965 +1
==========================================
- Hits 14420 14418 -2
- Misses 2631 2634 +3
Partials 913 913 ☔ View full report in Codecov by Sentry. |
…in RollbackWindow Signed-off-by: Alex Dunn <[email protected]>
Signed-off-by: Alex Dunn <[email protected]>
E2E Tests Published Test Results 4 files 4 suites 3h 23m 48s ⏱️ For more details on these failures, see this check. Results for commit 2ed5b66. |
zachaller
approved these changes
Jun 27, 2024
zachaller
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ysis Runs. Fixes #3669 (#3670) * Ensure that BackgroundAnalysisRun does not run when rolling back within RollbackWindow Signed-off-by: Alex Dunn <[email protected]> * Fix linting Signed-off-by: Alex Dunn <[email protected]> --------- Signed-off-by: Alex Dunn <[email protected]>
zachaller
added
the
cherry-pick-completed
meeech
pushed a commit
to CircleCI-Public/argo-rollouts
that referenced
this pull request
Feb 10, 2025
…ysis Runs. Fixes argoproj#3669 (argoproj#3670) * Ensure that BackgroundAnalysisRun does not run when rolling back within RollbackWindow Signed-off-by: Alex Dunn <[email protected]> * Fix linting Signed-off-by: Alex Dunn <[email protected]> --------- Signed-off-by: Alex Dunn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix an issue with Background (and other) Analysis runs from running when rolling back to a revision within a Rollback Window. I'm not incredibly well versed with how testing is done within this project or golang in general, so any assistance in that area would be appreciated. That being said I did give it a best effort.
I originally discovered the issue described in #3669 in v1.6.6, where by rolling back an application within a rollback window unexpectedly ran a background analysis which could fail, causing a rapid scale up and down of the application's replicaset. To reconcile that issue the failed background analysis run needed to be deleted. I am unable to easily reproduce that issue, but considering that we didn't expect any background analysis to run when rolling back to a revision within a rollback window, this PR should address that issue.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".