Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix premature scaledown #365

Merged
merged 2 commits into from
Jan 22, 2020
Merged

fix: Fix premature scaledown #365

merged 2 commits into from
Jan 22, 2020

Conversation

dthomson25
Copy link
Member

No description provided.

@dthomson25 dthomson25 changed the title Fix premature scaledown fix: Fix premature scaledown Jan 17, 2020
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #365 into master will decrease coverage by 0.27%.
The diff coverage is 48.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #365      +/-   ##
=========================================
- Coverage   83.97%   83.7%   -0.28%     
=========================================
  Files          70      70              
  Lines        6528    6534       +6     
=========================================
- Hits         5482    5469      -13     
- Misses        750     772      +22     
+ Partials      296     293       -3
Impacted Files Coverage Δ
rollout/canary.go 86.23% <100%> (-0.12%) ⬇️
rollout/bluegreen.go 77.67% <45.16%> (-4.77%) ⬇️
rollout/replicaset.go 65.38% <50%> (-9.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b63c9...ef9993f. Read the comment docs.

rollout/bluegreen.go Show resolved Hide resolved
rollout/bluegreen.go Show resolved Hide resolved
@dthomson25 dthomson25 merged commit 9b9f341 into master Jan 22, 2020
@dthomson25 dthomson25 deleted the fix-scaling branch January 22, 2020 02:17
dthomson25 added a commit that referenced this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants