feat: Implement watch for Istio resources #354
Conversation
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
- Coverage 83.97% 83.75% -0.23%
==========================================
Files 70 70
Lines 6528 6593 +65
==========================================
+ Hits 5482 5522 +40
- Misses 750 774 +24
- Partials 296 297 +1
Continue to review full report at Codecov.
|
dthomson25
force-pushed
the
istio-informer
branch
from
046e271 to
62a8a5b
Compare
dthomson25
changed the title
dthomson25
force-pushed
the
istio-informer
branch
from
62a8a5b to
ceab1e0
Compare
dthomson25
force-pushed
the
istio-informer
branch
2 times, most recently
from
3d72488 to
f6c7d97
Compare
dthomson25
force-pushed
the
istio-informer
branch
from
f6c7d97 to
4592a97
Compare
| for watchEvent := range watchI.ResultChan() { | ||
| processNextWatchObj(watchEvent, queue, indexer, index) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
There should be a watchI.Stop() call which will clean up resources held by the watch.
| } | ||
| err := WatchResource(client, namespace, gvk, queue, indexer, index) | ||
| if err == nil { | ||
| continue |
There was a problem hiding this comment.
Minor, but If there is no error, I would suggest that we "reset" the exponential backoff by re-initializing the backoff variable.
| acc, err := meta.Accessor(obj) | ||
| if err != nil { | ||
| log.Errorf("Error processing object from watch: %v", err) | ||
| return |
There was a problem hiding this comment.
Is there a reason you don't surface these errors to the caller? I'm afraid that we might get into an error hotloop which we will not back off from with the exponential backoff
Actually, nevermind, we might get here because of normal stream closes, which we would not want to backoff from, and is covered by the closing of the ResultChan()
To ensure the controller maintains the desired state of the virtual service, this PR adds a watch on virtual services and enqueues rollout that reference those virtual services.