fix: using our own pod template hashing #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrii Perenesenko <[email protected]>
Signed-off-by: Andrii Perenesenko <[email protected]>
Signed-off-by: Andrii Perenesenko <[email protected]>
huikang
reviewed
Jan 27, 2022
Signed-off-by: Andrii Perenesenko <[email protected]>
# Conflicts: # rollout/controller_test.go # utils/conditions/rollouts_test.go # utils/experiment/experiment_test.go
Signed-off-by: Andrii Perenesenko <[email protected]>
Signed-off-by: Andrii Perenesenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
- Coverage 82.33% 82.26% -0.07%
==========================================
Files 116 117 +1
Lines 16393 16419 +26
==========================================
+ Hits 13497 13507 +10
- Misses 2217 2231 +14
- Partials 679 681 +2
Continue to review full report at Codecov.
|
Signed-off-by: Andrii Perenesenko <[email protected]>
…meter to the FindOldReplicaSets as it using only right after the FindNewReplicaSet Signed-off-by: Andrii Perenesenko <[email protected]>
Signed-off-by: Andrii Perenesenko <[email protected]>
# Conflicts: # rollout/experiment_test.go
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1356
Checklist:
"fix(controller): Updates such and such. Fixes #1234".