Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ALB status should be a pointer #1766

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

jessesuen
Copy link
Member

@jessesuen jessesuen commented Jan 13, 2022

Resolves #1705

Signed-off-by: Jesse Suen [email protected]

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1766 (8bedb42) into master (4739bcd) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
- Coverage   82.03%   82.03%   -0.01%     
==========================================
  Files         116      116              
  Lines       16171    16175       +4     
==========================================
+ Hits        13266    13269       +3     
- Misses       2226     2227       +1     
  Partials      679      679              
Impacted Files Coverage Δ
rollout/trafficrouting/alb/alb.go 82.12% <75.00%> (-0.15%) ⬇️
analysis/analysis.go 86.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bf576...8bedb42. Read the comment docs.

@jessesuen jessesuen marked this pull request as draft January 13, 2022 22:04
@jessesuen jessesuen changed the title chore: run codegen. ALB status should be a pointer chore: ALB status should be a pointer Jan 13, 2022
@jessesuen jessesuen force-pushed the alb-status-pointer branch 3 times, most recently from 76ffb90 to 42268f6 Compare January 13, 2022 23:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@jessesuen jessesuen marked this pull request as ready for review January 13, 2022 23:20
@jessesuen jessesuen merged commit f419820 into argoproj:master Jan 14, 2022
@jessesuen jessesuen deleted the alb-status-pointer branch January 14, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status.ALBStatus should be a pointer
2 participants