fix: continue update process in middle of update if spec.replicas is 0 #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
force-pushed
the
1690-canary-not-trigger-weight-zero
branch
3 times, most recently
from
5d8eb22 to
e91436e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
+ Coverage 82.03% 82.05% +0.01%
==========================================
Files 116 116
Lines 16175 16219 +44
==========================================
+ Hits 13269 13308 +39
- Misses 2227 2231 +4
- Partials 679 680 +1
Continue to review full report at Codecov.
|
- if canary.spec.replicas==0 as in the canary steps, update continues Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
1690-canary-not-trigger-weight-zero
branch
from
e91436e to
abc8029
Compare
|
thanks for fixing the issue. @huikang |
utils/replicaset/replicaset.go
Outdated
| @@ -630,5 +630,5 @@ func IsReplicaSetReady(rs *appsv1.ReplicaSet) bool { | |||
| } | |||
| replicas := rs.Spec.Replicas | |||
| readyReplicas := rs.Status.ReadyReplicas | |||
| return replicas != nil && *replicas != 0 && readyReplicas != 0 && *replicas <= readyReplicas | |||
| return (replicas != nil && *replicas != 0 && readyReplicas != 0 && *replicas <= readyReplicas) || (replicas != nil && *replicas == 0) | |||
There was a problem hiding this comment.
can you update description to the function with added condition
utils/replicaset/replicaset.go
Outdated
| @@ -630,5 +630,5 @@ func IsReplicaSetReady(rs *appsv1.ReplicaSet) bool { | |||
| } | |||
| replicas := rs.Spec.Replicas | |||
| readyReplicas := rs.Status.ReadyReplicas | |||
| return replicas != nil && *replicas != 0 && readyReplicas != 0 && *replicas <= readyReplicas | |||
| return (replicas != nil && *replicas != 0 && readyReplicas != 0 && *replicas <= readyReplicas) || (replicas != nil && *replicas == 0) | |||
There was a problem hiding this comment.
can you please add the given scenario as an e2e test?
huikang
force-pushed
the
1690-canary-not-trigger-weight-zero
branch
7 times, most recently
from
040f91f to
d0c2d2a
Compare
… intermediate replicaset Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
1690-canary-not-trigger-weight-zero
branch
from
d0c2d2a to
4d1e68d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jessesuen
approved these changes
Jan 18, 2022
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang [email protected]
fix #1690
Checklist:
"fix(controller): Updates such and such. Fixes #1234".