feat: ping-pong services #1697

perenesenko · 2021-12-10T19:00:48Z

Fix for: #1453

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

Signed-off-by: Andrii Perenesenko <[email protected]>

…inal tool Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>

codecov · 2021-12-22T19:37:13Z

Codecov Report

Merging #1697 (94412cc) into master (5f0f8b4) will increase coverage by 0.09%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   82.26%   82.35%   +0.09%     
==========================================
  Files         119      119              
  Lines       16811    16864      +53     
==========================================
+ Hits        13830    13889      +59     
+ Misses       2288     2284       -4     
+ Partials      693      691       -2

Impacted Files	Coverage Δ
pkg/kubectl-argo-rollouts/cmd/get/get.go	`72.00% <ø> (ø)`
pkg/kubectl-argo-rollouts/info/info.go	`100.00% <ø> (ø)`
rollout/canary.go	`76.32% <50.00%> (-0.52%)`	⬇️
rollout/controller.go	`77.75% <92.50%> (+1.26%)`	⬆️
pkg/apis/rollouts/validation/validation.go	`94.35% <100.00%> (+0.38%)`	⬆️
.../apis/rollouts/validation/validation_references.go	`87.42% <100.00%> (+0.15%)`	⬆️
pkg/kubectl-argo-rollouts/cmd/get/get_rollout.go	`98.55% <100.00%> (+0.05%)`	⬆️
pkg/kubectl-argo-rollouts/info/replicaset_info.go	`80.19% <100.00%> (+1.70%)`	⬆️
pkg/kubectl-argo-rollouts/info/rollout_info.go	`87.89% <100.00%> (+0.39%)`	⬆️
rollout/service.go	`77.72% <100.00%> (+0.68%)`	⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f0f8b4...94412cc. Read the comment docs.

Signed-off-by: Andrii Perenesenko <[email protected]>

… pong services Signed-off-by: Andrii Perenesenko <[email protected]>

rollout/trafficrouting/service_helper.go

harikrongali · 2022-01-12T14:46:15Z

@perenesenko can you add documentation as well?
overall code looks good to me.

Signed-off-by: Andrii Perenesenko <[email protected]>

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go # pkg/apis/rollouts/v1alpha1/generated.proto # pkg/apis/rollouts/v1alpha1/openapi_generated.go

Signed-off-by: Andrii Perenesenko <[email protected]>

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

Signed-off-by: Andrii Perenesenko <[email protected]>

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

Signed-off-by: Andrii Perenesenko <[email protected]>

jessesuen

Minor request to ensure this is not used with other traffic routers.

pkg/apis/rollouts/validation/validation.go

Signed-off-by: Andrii Perenesenko <[email protected]>

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

Signed-off-by: Andrii Perenesenko <[email protected]>

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go # test/e2e/aws_test.go

Signed-off-by: Andrii Perenesenko <[email protected]>

jessesuen

Great job!

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

Signed-off-by: Andrii Perenesenko <[email protected]>

sonarqubecloud · 2022-02-04T00:36:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

No Coverage information
4.3% Duplication

perenesenko changed the title ~~Ping pong~~ feat: ping-pong services Dec 10, 2021

perenesenko requested a review from jessesuen December 13, 2021 18:24

perenesenko force-pushed the ping-pong branch from 713dfe4 to d333712 Compare December 13, 2021 21:59

perenesenko marked this pull request as ready for review December 15, 2021 19:13

perenesenko added 10 commits December 15, 2021 11:17

codegen before

9aac872

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong reconcile services

5969473

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong reconcile alb traffic

693b6af

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong scaling down the otherRs

996720b

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong, refactoring extract getReferencedService method

93ed41b

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong services validation

f6ef5d9

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong services to display in the kubectl-argo-rollouts term…

e6ecce8

…inal tool Signed-off-by: Andrii Perenesenko <[email protected]>

fix lint error for the rollout package

822fb54

Signed-off-by: Andrii Perenesenko <[email protected]>

fix merge errors

92032bc

Signed-off-by: Andrii Perenesenko <[email protected]>

codegen

5fcde84

Signed-off-by: Andrii Perenesenko <[email protected]>

perenesenko force-pushed the ping-pong branch from ba550af to 5fcde84 Compare December 15, 2021 22:49

perenesenko added 5 commits December 20, 2021 16:36

feat: ping-pong, tests

9d38b43

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong, tests

6064c40

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong, tests, reuse assertWeights method

774c918

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: ping-pong, simplify code in a reconcilePingAndPongService

9ee383d

Signed-off-by: Andrii Perenesenko <[email protected]>

feat: fix tests, ordering the stableService, canaryService

e92f710

Signed-off-by: Andrii Perenesenko <[email protected]>

perenesenko added 9 commits December 22, 2021 17:05

feat: set the root service field required for alb and ping-pong

c2faa97

Signed-off-by: Andrii Perenesenko <[email protected]>

tests for ping-pong validation

7ed0f7f

Signed-off-by: Andrii Perenesenko <[email protected]>

test swapping ping and pong

b1d2f25

Signed-off-by: Andrii Perenesenko <[email protected]>

tests for validation

b0fb0f2

Signed-off-by: Andrii Perenesenko <[email protected]>

tests TestPromoteStable

35ce2a2

Signed-off-by: Andrii Perenesenko <[email protected]>

tests TestReconcilePingAndPongService

ad1ca10

Signed-off-by: Andrii Perenesenko <[email protected]>

tests TestPingPongCanaryRolloutInfo

c03c681

Signed-off-by: Andrii Perenesenko <[email protected]>

remove bad test TestPingPongCanaryPromoteFull

af40c6c

Signed-off-by: Andrii Perenesenko <[email protected]>

test TestCanaryRolloutWithPingPongServices also test invalid ping and…

498e038

… pong services Signed-off-by: Andrii Perenesenko <[email protected]>

harikrongali reviewed Jan 12, 2022

View reviewed changes

rollout/trafficrouting/service_helper.go Outdated Show resolved Hide resolved

harikrongali reviewed Jan 12, 2022

View reviewed changes

rollout/trafficrouting/service_helper.go Outdated Show resolved Hide resolved

perenesenko added 3 commits January 12, 2022 12:48

remove the unused/commented code. inline the PingPongOpposite method

0e6168a

Signed-off-by: Andrii Perenesenko <[email protected]>

Merge branch 'master' into ping-pong

50a8ead

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go # pkg/apis/rollouts/v1alpha1/generated.proto # pkg/apis/rollouts/v1alpha1/openapi_generated.go

launch codegen after the merge

5103ea7

Signed-off-by: Andrii Perenesenko <[email protected]>

perenesenko force-pushed the ping-pong branch from f673433 to 5103ea7 Compare January 15, 2022 00:02

perenesenko added 6 commits January 18, 2022 11:59

fixing the codegen issue

25fd2f4

Signed-off-by: Andrii Perenesenko <[email protected]>

Merge branch 'master' into ping-pong

d6ba2df

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

adding documentation for the ping-pong

1e4454a

Signed-off-by: Andrii Perenesenko <[email protected]>

Merge branch 'master' into ping-pong

e260fc9

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

launch codegen after merging from master

c625d64

Signed-off-by: Andrii Perenesenko <[email protected]>

switch the ping/pong service labels regardless the RS availability

fcf18a4

Signed-off-by: Andrii Perenesenko <[email protected]>

harikrongali approved these changes Jan 22, 2022

View reviewed changes

harikrongali added the ready-for-review Ready for final review label Jan 22, 2022

perenesenko added 2 commits January 31, 2022 14:27

Merge branch 'master' into ping-pong

d3d0a6d

fix lint error after the merge

1fad6ba

Signed-off-by: Andrii Perenesenko <[email protected]>

jessesuen reviewed Feb 1, 2022

View reviewed changes

pkg/apis/rollouts/validation/validation.go Show resolved Hide resolved

perenesenko added 4 commits February 1, 2022 12:35

adding validation so ping-pong feature support only ALB traffic routing

c54e1b3

Signed-off-by: Andrii Perenesenko <[email protected]>

Merge branch 'master' into ping-pong

e79f70c

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

codegen after merge

0d1d08e

Signed-off-by: Andrii Perenesenko <[email protected]>

adding validation so ping-pong feature support only ALB traffic routing

962e9a1

Signed-off-by: Andrii Perenesenko <[email protected]>

perenesenko force-pushed the ping-pong branch from 85888d6 to 962e9a1 Compare February 2, 2022 00:35

perenesenko added 2 commits February 2, 2022 10:28

Merge branch 'master' into ping-pong

7a2ef91

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go # test/e2e/aws_test.go

codegen after merge

9eb2d48

Signed-off-by: Andrii Perenesenko <[email protected]>

jessesuen approved these changes Feb 3, 2022

View reviewed changes

perenesenko added 2 commits February 3, 2022 16:28

Merge branch 'master' into ping-pong

13848d1

# Conflicts: # pkg/apis/rollouts/v1alpha1/generated.pb.go

codegen after merge

94412cc

Signed-off-by: Andrii Perenesenko <[email protected]>

jessesuen merged commit 34b4375 into argoproj:master Feb 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ping-pong services #1697

feat: ping-pong services #1697

perenesenko commented Dec 10, 2021 •

edited

Loading

codecov bot commented Dec 22, 2021 •

edited

Loading

harikrongali commented Jan 12, 2022

jessesuen left a comment

jessesuen left a comment

sonarqubecloud bot commented Feb 4, 2022

feat: ping-pong services #1697

feat: ping-pong services #1697

Conversation

perenesenko commented Dec 10, 2021 • edited Loading

codecov bot commented Dec 22, 2021 • edited Loading

Codecov Report

harikrongali commented Jan 12, 2022

jessesuen left a comment

Choose a reason for hiding this comment

jessesuen left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 4, 2022

perenesenko commented Dec 10, 2021 •

edited

Loading

codecov bot commented Dec 22, 2021 •

edited

Loading