chore(docs): Updated FAQs #1695

pbaderia01 · 2021-12-09T13:00:39Z

Chore to remove a sentence accidentally added twice.

Signed-off-by: Piyush Baderia [email protected]

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

Chore to remove a sentence accidentally added twice. Signed-off-by: Piyush Baderia <[email protected]>

codecov · 2021-12-09T17:13:16Z

Codecov Report

Merging #1695 (9ec119e) into master (4d3b992) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9ec119e differs from pull request most recent head b812ce5. Consider uploading reports for the commit b812ce5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   82.07%   82.06%   -0.01%     
==========================================
  Files         116      116              
  Lines       16064    16073       +9     
==========================================
+ Hits        13184    13190       +6     
- Misses       2208     2210       +2     
- Partials      672      673       +1

Impacted Files	Coverage Δ
rollout/trafficrouting/istio/controller.go	`50.81% <0.00%> (-1.63%)`	⬇️
rollout/temlateref.go	`82.98% <0.00%> (+0.82%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3b992...b812ce5. Read the comment docs.

Signed-off-by: Piyush Baderia <[email protected]>

jessesuen · 2021-12-11T19:42:30Z

Makefile

@@ -244,7 +244,7 @@ start-e2e:

 .PHONY: test-e2e
 test-e2e:
-	go test -timeout 30m -v -count 1 --tags e2e -p ${E2E_PARALLEL} --short ./test/e2e ${E2E_TEST_OPTIONS}
+	go test -timeout 60m -v -count 1 --tags e2e -p ${E2E_PARALLEL} --short ./test/e2e ${E2E_TEST_OPTIONS}


Can you revert this change? The e2e failure was not related to exceeding 30m timeout, but general flakiness, which we are working on.

Hey @jessesuen! Sure! I saw a couple of actions that were timing around 30m so figured I'd try running the action with an increased timeout. Reverting the change immediately.