Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin sys module in go.mod to resolve a fatal runtime execution in go 1.17 #1692

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

huikang
Copy link
Member

@huikang huikang commented Dec 9, 2021

Signed-off-by: Hui Kang [email protected]

close #1693

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@huikang huikang changed the title chore: pin sys module to resolve a fatal runtime execution in go 1.17 chore: pin sys module in go.mod to resolve a fatal runtime execution in go 1.17 Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1692 (004daf4) into master (4d3b992) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   82.07%   82.06%   -0.01%     
==========================================
  Files         116      116              
  Lines       16064    16073       +9     
==========================================
+ Hits        13184    13190       +6     
- Misses       2208     2210       +2     
- Partials      672      673       +1     
Impacted Files Coverage Δ
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️
rollout/temlateref.go 82.98% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3b992...004daf4. Read the comment docs.

@jessesuen
Copy link
Member

Some reason codegen verify is failed. Do you know why?

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for unblocking me! LGTM

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed CI failed. @huikang , Can you please run go mod download && go mod tidy to make codegen happy?

Signed-off-by: Hui Kang <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@huikang
Copy link
Member Author

huikang commented Dec 10, 2021

@jessesuen , @alexmt 's suggestion makes the codegen test passed. Thanks.

@alexmt alexmt merged commit c67735a into argoproj:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal runtime execution using go 1.17
3 participants