-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pin sys module in go.mod to resolve a fatal runtime execution in go 1.17 #1692
chore: pin sys module in go.mod to resolve a fatal runtime execution in go 1.17 #1692
Conversation
Signed-off-by: Hui Kang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
- Coverage 82.07% 82.06% -0.01%
==========================================
Files 116 116
Lines 16064 16073 +9
==========================================
+ Hits 13184 13190 +6
- Misses 2208 2210 +2
- Partials 672 673 +1
Continue to review full report at Codecov.
|
Some reason codegen verify is failed. Do you know why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for unblocking me! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed CI failed. @huikang , Can you please run go mod download && go mod tidy
to make codegen happy?
Signed-off-by: Hui Kang <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
@jessesuen , @alexmt 's suggestion makes the codegen test passed. Thanks. |
Signed-off-by: Hui Kang [email protected]
close #1693
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.