fix: sending updates to dashboard when a pod terminates #1642

perenesenko · 2021-11-10T18:24:37Z

Signed-off-by: Andrii Perenesenko [email protected]

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

codecov · 2021-11-10T18:35:13Z

Codecov Report

Merging #1642 (c651128) into master (f77b2c5) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1642      +/-   ##
==========================================
+ Coverage   81.94%   81.99%   +0.04%     
==========================================
  Files         115      116       +1     
  Lines       15871    15929      +58     
==========================================
+ Hits        13006    13061      +55     
- Misses       2196     2198       +2     
- Partials      669      670       +1

Impacted Files	Coverage Δ
controller/metrics/metrics.go	`100.00% <0.00%> (ø)`
utils/conditions/conditions.go	`80.76% <0.00%> (ø)`
controller/metrics/prommetrics.go	`100.00% <0.00%> (ø)`
rollout/controller.go	`74.71% <0.00%> (+0.04%)`	⬆️
rollout/trafficrouting/istio/istio.go	`81.16% <0.00%> (+0.22%)`	⬆️
rollout/sync.go	`78.29% <0.00%> (+0.36%)`	⬆️
rollout/trafficrouting/alb/alb.go	`84.94% <0.00%> (+0.94%)`	⬆️
rollout/trafficrouting.go	`69.74% <0.00%> (+1.12%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77b2c5...c651128. Read the comment docs.