fix: validate service selctor labels matching rollout template labels #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
1566-validate-service-labels
branch
2 times, most recently
from
694af7d to
b2d836c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
+ Coverage 81.76% 81.78% +0.01%
==========================================
Files 113 113
Lines 15563 15577 +14
==========================================
+ Hits 12725 12739 +14
Misses 2176 2176
Partials 662 662
Continue to review full report at Codecov.
|
huikang
force-pushed
the
1566-validate-service-labels
branch
2 times, most recently
from
0f8190c to
90059bb
Compare
…abels - fix e2e test Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
1566-validate-service-labels
branch
from
90059bb to
e20f3f9
Compare
Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
1566-validate-service-labels
branch
from
096ee1c to
ac2ce08
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jessesuen
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang [email protected]
close #1566
Checklist:
"fix(controller): Updates such and such. Fixes #1234".