-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Istio Subset-Level TrafficRouting with experiment step #1602
feat: Istio Subset-Level TrafficRouting with experiment step #1602
Conversation
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
…to istio-subset-lvl-exp-step
Signed-off-by: khhirani <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 81.77% 81.96% +0.18%
==========================================
Files 113 115 +2
Lines 15573 15885 +312
==========================================
+ Hits 12735 13020 +285
- Misses 2176 2196 +20
- Partials 662 669 +7
Continue to review full report at Codecov.
|
@khhirani please resolve merge conflicts..will review after resolving merge conflicts |
…to istio-subset-lvl-exp-step
…to istio-subset-lvl-exp-step
…to istio-subset-lvl-exp-step
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The code looks good to me.
@khhirani @harikrongali |
@perenesenko we have an enhancement reported for that #1463 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As described in comments of #1059