Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Istio Subset-Level TrafficRouting with experiment step #1602

Merged
merged 10 commits into from
Nov 15, 2021

Conversation

khhirani
Copy link
Contributor

As described in comments of #1059

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1602 (b3913c9) into master (9d2ccb9) will increase coverage by 0.18%.
The diff coverage is 77.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   81.77%   81.96%   +0.18%     
==========================================
  Files         113      115       +2     
  Lines       15573    15885     +312     
==========================================
+ Hits        12735    13020     +285     
- Misses       2176     2196      +20     
- Partials      662      669       +7     
Impacted Files Coverage Δ
rollout/trafficrouting/alb/alb.go 84.00% <0.00%> (ø)
rollout/trafficrouting/nginx/nginx.go 80.19% <0.00%> (ø)
rollout/trafficrouting/smi/smi.go 94.90% <0.00%> (ø)
rollout/trafficrouting.go 68.78% <66.66%> (+0.16%) ⬆️
rollout/trafficrouting/istio/istio.go 81.16% <88.88%> (+0.22%) ⬆️
rollout/trafficrouting/ambassador/ambassador.go 83.15% <100.00%> (ø)
controller/metrics/metrics.go 100.00% <0.00%> (ø)
controller/controller.go 89.45% <0.00%> (ø)
controller/healthz.go 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2ccb9...b3913c9. Read the comment docs.

@harikrongali
Copy link
Contributor

@khhirani please resolve merge conflicts..will review after resolving merge conflicts

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
7.7% 7.7% Duplication

@perenesenko
Copy link
Member

The code looks good to me.
The question I have are we going to show the experiment traffic somehow on a argo-rollout console view?

Name:            rollouts-demo
Namespace:       default
Status:          ॥ Paused
Message:         CanaryPauseStep
Strategy:        Canary
  Step:          3/4
  SetWeight:     20
  ActualWeight:  20
Images:          argoproj/rollouts-demo:orange (canary)
                 argoproj/rollouts-demo:red (stable)

@khhirani @harikrongali
We do show the canary weight 20 there but are we going to display the experiment also?

@harikrongali
Copy link
Contributor

@perenesenko we have an enhancement reported for that #1463

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khhirani khhirani merged commit b80b563 into argoproj:master Nov 15, 2021
@khhirani khhirani deleted the istio-subset-lvl-exp-step branch November 15, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants