Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifests): Add Age column to all CRD(s). Fixes #1511 #1527

Merged
merged 4 commits into from
Nov 8, 2021
Merged

feat(manifests): Add Age column to all CRD(s). Fixes #1511 #1527

merged 4 commits into from
Nov 8, 2021

Conversation

yashmehrotra
Copy link
Contributor

@yashmehrotra yashmehrotra commented Sep 21, 2021

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@yashmehrotra
Copy link
Contributor Author

My organization is not added to the USERS.md, should I add it as part of this PR or create a separate PR ?

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1527 (b4bc41c) into master (ac155f1) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1527      +/-   ##
==========================================
+ Coverage   81.76%   81.93%   +0.17%     
==========================================
  Files         113      115       +2     
  Lines       15563    15861     +298     
==========================================
+ Hits        12725    12996     +271     
- Misses       2176     2196      +20     
- Partials      662      669       +7     
Impacted Files Coverage Δ
utils/ingress/ingress.go 100.00% <0.00%> (ø)
controller/metrics/metrics.go 100.00% <0.00%> (ø)
controller/healthz.go 100.00% <0.00%> (ø)
controller/controller.go 89.45% <0.00%> (ø)
pkg/kubectl-argo-rollouts/cmd/status/status.go 93.75% <0.00%> (+0.41%) ⬆️
metricproviders/webmetric/webmetric.go 67.22% <0.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac155f1...b4bc41c. Read the comment docs.

@yashmehrotra
Copy link
Contributor Author

The Docker and E2E tests failed due to flakiness

Regarding the codegen, what should I do to make it green ? Since there is a change in the CRDs

@jessesuen
Copy link
Member

Regarding the codegen, what should I do to make it green ? Since there is a change in the CRDs

run make codegen and commit changes

My organization is not added to the USERS.md, should I add it as part of this PR or create a separate PR ?

Thanks for adding! You can include as part of this PR or separate. Either is fine

@yashmehrotra
Copy link
Contributor Author

@jessesuen Thanks, I have ran the make codegen and commited the changes. The CI should pass now

Have also added my org. in this PR itself.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@yashmehrotra
Copy link
Contributor Author

@jessesuen Can you please take a look whenever you have time ?

@huikang
Copy link
Member

huikang commented Oct 27, 2021

@yashmehrotra , there is a conflict. Could you resolve it? Thanks.

@yashmehrotra
Copy link
Contributor Author

@huikang Have resolved the conflict

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.7% 4.7% Duplication

@jessesuen jessesuen merged commit 3ad0417 into argoproj:master Nov 8, 2021
@yashmehrotra yashmehrotra deleted the age-to-crds branch November 9, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants