-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifests): Add Age column to all CRD(s). Fixes #1511 #1527
Conversation
My organization is not added to the USERS.md, should I add it as part of this PR or create a separate PR ? |
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
==========================================
+ Coverage 81.76% 81.93% +0.17%
==========================================
Files 113 115 +2
Lines 15563 15861 +298
==========================================
+ Hits 12725 12996 +271
- Misses 2176 2196 +20
- Partials 662 669 +7
Continue to review full report at Codecov.
|
The Docker and E2E tests failed due to flakiness Regarding the codegen, what should I do to make it green ? Since there is a change in the CRDs |
run
Thanks for adding! You can include as part of this PR or separate. Either is fine |
Signed-off-by: Yash Mehrotra <[email protected]>
Signed-off-by: Yash Mehrotra <[email protected]>
@jessesuen Thanks, I have ran the Have also added my org. in this PR itself. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@jessesuen Can you please take a look whenever you have time ? |
@yashmehrotra , there is a conflict. Could you resolve it? Thanks. |
@huikang Have resolved the conflict |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.