Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add some more explanation around TLS routes in Istio-based Rollouts README #1414

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

agrawroh
Copy link
Member

@agrawroh agrawroh commented Aug 12, 2021

This PR adds some more clarification around handling of TLS/HTTPS routes in Istio-based Argo Rollouts.

Preview Link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@agrawroh agrawroh force-pushed the argo-vs-readme-changes branch from c88a0b1 to ac1ab67 Compare August 12, 2021 16:04
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #1414 (490e34f) into master (0b70775) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1414   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         108      108           
  Lines       10043    10043           
=======================================
  Hits         8173     8173           
  Misses       1309     1309           
  Partials      561      561           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b70775...490e34f. Read the comment docs.

@agrawroh agrawroh force-pushed the argo-vs-readme-changes branch from ac1ab67 to 8d36d53 Compare August 14, 2021 15:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

@jessesuen jessesuen merged commit 6141685 into argoproj:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants