Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TrafficRouting SMI with Experiment Step in Canary #1351

Merged
merged 92 commits into from
Aug 23, 2021

Conversation

khhirani
Copy link
Contributor

As described in comments of #1059

khhirani added 30 commits May 10, 2021 20:46
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
@khhirani khhirani requested a review from jessesuen July 27, 2021 22:56
test/e2e/smi_test.go Show resolved Hide resolved
rollout/trafficrouting.go Outdated Show resolved Hide resolved
rollout/trafficrouting/alb/alb.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
@khhirani khhirani requested a review from jessesuen August 5, 2021 17:44
rollout/trafficrouting/istio/istio.go Outdated Show resolved Hide resolved
rollout/trafficrouting/nginx/nginx.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi.go Outdated Show resolved Hide resolved
rollout/trafficrouting/smi/smi_test.go Outdated Show resolved Hide resolved
Signed-off-by: khhirani <[email protected]>
@khhirani khhirani requested a review from jessesuen August 5, 2021 19:50
rollout/trafficrouting.go Outdated Show resolved Hide resolved
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind sorting all imports? Not just the ones I'm calling out.

rollout/trafficrouting/ambassador/ambassador.go Outdated Show resolved Hide resolved
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
rollout/trafficrouting.go Outdated Show resolved Hide resolved
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
@khhirani khhirani force-pushed the trafficsplit-smi-exp-step branch from a5e96a9 to 0dafa0e Compare August 6, 2021 21:00
@khhirani khhirani requested a review from jessesuen August 6, 2021 21:03
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash all 91 commits, and clean the commit message when merging.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
4.8% 4.8% Duplication

@khhirani khhirani merged commit 986d4b0 into argoproj:master Aug 23, 2021
@khhirani khhirani deleted the trafficsplit-smi-exp-step branch August 23, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants