feat: verify AWS TargetGroup after updating active/stable services #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
force-pushed
the
verify-targetgroups
branch
2 times, most recently
from
37a550f to
070fb1d
Compare
jessesuen
changed the title
jessesuen
changed the title
jessesuen
changed the title
jessesuen
force-pushed
the
verify-targetgroups
branch
2 times, most recently
from
9009511 to
9658ec9
Compare
jessesuen
force-pushed
the
verify-targetgroups
branch
from
9658ec9 to
2ac6e69
Compare
jessesuen
changed the title
Signed-off-by: Jesse Suen <[email protected]>
jessesuen
force-pushed
the
verify-targetgroups
branch
4 times, most recently
from
27d4fd3 to
3acbe72
Compare
Codecov Report
@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
- Coverage 81.54% 81.37% -0.17%
==========================================
Files 108 108
Lines 10104 14450 +4346
==========================================
+ Hits 8239 11759 +3520
- Misses 1304 2077 +773
- Partials 561 614 +53
Continue to review full report at Codecov.
|
jessesuen
force-pushed
the
verify-targetgroups
branch
6 times, most recently
from
67374ec to
cf03dcf
Compare
jessesuen
force-pushed
the
verify-targetgroups
branch
from
cf03dcf to
a5239bf
Compare
Signed-off-by: Jesse Suen <[email protected]>
jessesuen
force-pushed
the
verify-targetgroups
branch
from
a5239bf to
2bf6d80
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements approach 1 in #1283.
During a blue-green update, the rollout controller will verify the AWS target group for the active service is correctly targeting the correct pod endpoints of the new replicaset after the active service has switched to point to new revision. This is executed/verified before postPromotionAnalysis runs.
During a canary update with ALB traffic routing, the rollout controller will verify the AWS target group of the stable service after modifying the selector, before attaching the scaleDownDelay annotation to the ReplicaSet, thereby preventing scaledown of the old ReplicaSet until targets have been verified.
One major changes done as part of this PR is: the injection of the scale-down-deadline annotation is now performed in followup reconciliations, as opposed the the point in time when the stable is promoted. This change is imperceivable to users, but affected assumptions of many tests.
Signed-off-by: Jesse Suen [email protected]