Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Empty root-path causes redirect loop #3967

Closed
2 tasks done
thejoeejoee opened this issue Nov 30, 2024 · 0 comments · Fixed by #3968
Closed
2 tasks done

[dashboard] Empty root-path causes redirect loop #3967

thejoeejoee opened this issue Nov 30, 2024 · 0 comments · Fixed by #3968
Labels
bug Something isn't working dashboard

Comments

@thejoeejoee
Copy link
Contributor

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

When used dashboard on the plain non-prefixed URL (e.g. --root-path "" or --root-path "/"), dashboard server jumps into redirect loop.

To Reproduce

  • run kubectl argo rollouts dashboard --root-path "/"
  • enter http://localhost:3100

Expected behavior

Server should not return HTTP 302 with Location: / and just return the index.html of Dashboard.

Version

❯ kubectl argo rollouts version
kubectl-argo-rollouts: v1.7.2+59e5bd3
  BuildDate: 2024-08-13T18:29:47Z
  GitCommit: 59e5bd385c031600f86075beb9d77620f8d7915e
  GitTreeState: clean
  GoVersion: go1.21.13
  Compiler: gc
  Platform: darwin/amd64

Logs

❯ kubectl argo rollouts dashboard --root-path ""
INFO[0000] Argo Rollouts Dashboard is now available at http://localhost:3100/
❯ curl -iL http://localhost:3100/

...

HTTP/1.1 302 Found
Content-Type: text/html; charset=utf-8
Location: /
Date: Sat, 30 Nov 2024 13:44:45 GMT
Content-Length: 24

curl: (47) Maximum (50) redirects followed

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@thejoeejoee thejoeejoee added the bug Something isn't working label Nov 30, 2024
zachaller pushed a commit that referenced this issue Dec 4, 2024
…3968)

fix(dashboard): no redirect loop with running on root

Signed-off-by: Josef Kolář <[email protected]>
Rizwana777 pushed a commit to Rizwana777/argo-rollouts that referenced this issue Dec 12, 2024
…#3967 (argoproj#3968)

fix(dashboard): no redirect loop with running on root

Signed-off-by: Josef Kolář <[email protected]>
meeech pushed a commit to CircleCI-Public/argo-rollouts that referenced this issue Feb 10, 2025
…#3967 (argoproj#3968)

fix(dashboard): no redirect loop with running on root

Signed-off-by: Josef Kolář <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants