We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist:
Describe the bug
When used dashboard on the plain non-prefixed URL (e.g. --root-path "" or --root-path "/"), dashboard server jumps into redirect loop.
--root-path ""
--root-path "/"
To Reproduce
kubectl argo rollouts dashboard --root-path "/"
http://localhost:3100
Expected behavior
Server should not return HTTP 302 with Location: / and just return the index.html of Dashboard.
HTTP 302
Location: /
index.html
Version
❯ kubectl argo rollouts version kubectl-argo-rollouts: v1.7.2+59e5bd3 BuildDate: 2024-08-13T18:29:47Z GitCommit: 59e5bd385c031600f86075beb9d77620f8d7915e GitTreeState: clean GoVersion: go1.21.13 Compiler: gc Platform: darwin/amd64
Logs
❯ kubectl argo rollouts dashboard --root-path "" INFO[0000] Argo Rollouts Dashboard is now available at http://localhost:3100/
❯ curl -iL http://localhost:3100/ ... HTTP/1.1 302 Found Content-Type: text/html; charset=utf-8 Location: / Date: Sat, 30 Nov 2024 13:44:45 GMT Content-Length: 24 curl: (47) Maximum (50) redirects followed
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered:
fix(dashboard): No redirect loop when running on root. Fixes #3967 (#…
35147d3
…3968) fix(dashboard): no redirect loop with running on root Signed-off-by: Josef Kolář <[email protected]>
fix(dashboard): No redirect loop when running on root. Fixes argoproj…
6c1e606
…#3967 (argoproj#3968) fix(dashboard): no redirect loop with running on root Signed-off-by: Josef Kolář <[email protected]>
e658925
Successfully merging a pull request may close this issue.
Checklist:
Describe the bug
When used dashboard on the plain non-prefixed URL (e.g.
--root-path ""
or--root-path "/"
), dashboard server jumps into redirect loop.To Reproduce
kubectl argo rollouts dashboard --root-path "/"
http://localhost:3100
Expected behavior
Server should not return
HTTP 302
withLocation: /
and just return theindex.html
of Dashboard.Version
Logs
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered: