Skip to content

Commit

Permalink
docs: comment the details on the change
Browse files Browse the repository at this point in the history
Signed-off-by: Ravi Hari <[email protected]>
  • Loading branch information
RaviHari committed Jul 29, 2022
1 parent a38adb8 commit c403449
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rollout/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ func (c *Controller) writeBackToInformer(ro *v1alpha1.Rollout) {
// which the notification controller expects when it converts rolloutobject to toUnstructured and if not present
// and that throws an error "Failed to process: Object 'Kind' is missing in ..."
// Fixing this here as the informer is shared by notification controller by updating typemetafileds.
// TODO: Ned to revisit this in the future and maybe we should have a dedicated informer for notification
// TODO: Need to revisit this in the future and maybe we should have a dedicated informer for notification
gvk := un.GetObjectKind().GroupVersionKind()
if len(gvk.Version) == 0 || len(gvk.Group) == 0 || len(gvk.Kind) == 0 {
un.GetObjectKind().SetGroupVersionKind(schema.GroupVersionKind{
Expand Down

0 comments on commit c403449

Please sign in to comment.