Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
Signed-off-by: zachaller <[email protected]>
  • Loading branch information
zachaller committed Jun 29, 2022
1 parent ff6fb0d commit 7b7fec5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rollout/trafficrouting_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ func newFakeSingleTrafficRoutingReconciler() *mocks.TrafficRoutingReconciler {
trafficRoutingReconciler.On("Type").Return("fake")
trafficRoutingReconciler.On("SetWeight", mock.Anything, mock.Anything).Return(nil)
trafficRoutingReconciler.On("SetHeaderRoute", mock.Anything, mock.Anything).Return(nil)
trafficRoutingReconciler.On("SetMirrorRoute", mock.Anything, mock.Anything).Return(nil)
trafficRoutingReconciler.On("VerifyWeight", mock.Anything).Return(pointer.BoolPtr(true), nil)
trafficRoutingReconciler.On("UpdateHash", mock.Anything, mock.Anything, mock.Anything).Return(nil)
trafficRoutingReconciler.On("RemoveManagedRoutes", mock.Anything, mock.Anything).Return(nil)
return &trafficRoutingReconciler
}

Expand Down Expand Up @@ -437,7 +439,7 @@ func TestRolloutUseDynamicWeightOnPromoteFull(t *testing.T) {
f.fakeTrafficRouting.On("RemoveManagedRoutes", mock.Anything, mock.Anything).Return(nil)
f.fakeTrafficRouting.On("VerifyWeight", mock.Anything).Return(pointer.BoolPtr(true), nil)
f.run(getKey(r2, t))
})
})git

t.Run("DynamicStableScale false", func(t *testing.T) {
r2.Spec.Strategy.Canary.DynamicStableScale = false
Expand Down Expand Up @@ -493,6 +495,7 @@ func TestRolloutSetWeightToZeroWhenFullyRolledOut(t *testing.T) {
return nil
})
f.fakeTrafficRouting.On("SetHeaderRoute", mock.Anything, mock.Anything).Return(nil)
f.fakeTrafficRouting.On("RemoveManagedRoutes", mock.Anything, mock.Anything).Return(nil)
f.fakeTrafficRouting.On("VerifyWeight", mock.Anything).Return(pointer.BoolPtr(true), nil)
f.run(getKey(r1, t))
}
Expand Down

0 comments on commit 7b7fec5

Please sign in to comment.