fix(circleci build): Fix for circle ci build wrong dependency

Install golangci-lint binary directly, not as a dependency
argoproj · Feb 9, 2020 · 2ecab8d · 2ecab8d
1 parent 8e48153
commit 2ecab8d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -11,16 +11,16 @@ jobs:
     steps:
       - checkout
       - run: mkdir -p $TEST_RESULTS
-      - restore_cache:
-          keys:
-            - v3-pkg-cache
+      - run: go get github.com/jstemmer/go-junit-report
+      - run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.23.1
       - run:
           name: Install kustomize
           command: |
             curl -s "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh" | bash
             sudo mv kustomize /usr/local/bin/
-      - run: go get github.com/jstemmer/go-junit-report
-      - run: go get github.com/golangci/golangci-lint/cmd/golangci-lint
+      - restore_cache:
+          keys:
+            - v3-pkg-cache-{{ checksum "go.mod" }}
       - run:
           name: Run tests
           command: |
@@ -40,10 +40,10 @@ jobs:
           name: Check nothing has changed after lint
           command: git diff --exit-code
       - save_cache:
-          key: v3-pkg-cache
+          key: v3-pkg-cache-{{ checksum "go.sum" }}
           paths:
-            - /go/pkg
-            - ~/.cache/go-build
+            - /go/pkg/mod/
+            - ~/.cache/go-build/
 workflows:
   version: 2
   workflow:

diff --git a/go.mod b/go.mod
@@ -15,6 +15,7 @@ require (
 	github.com/googleapis/gnostic v0.2.0 // indirect
 	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect
 	github.com/imdario/mergo v0.3.6 // indirect
+	github.com/jstemmer/go-junit-report v0.9.1 // indirect
 	github.com/juju/ansiterm v0.0.0-20180109212912-720a0952cc2a
 	github.com/lunixbochs/vtclean v1.0.0 // indirect
 	github.com/mattn/go-colorable v0.1.4 // indirect

diff --git a/go.sum b/go.sum
@@ -259,6 +259,8 @@ github.com/json-iterator/go v1.1.6/go.mod h1:+SdeFBvtyEkXs7REEP0seUULqWtbJapLOCV
 github.com/json-iterator/go v1.1.7 h1:KfgG9LzI+pYjr4xvmz/5H4FXjokeP+rlHLhv3iH62Fo=
 github.com/json-iterator/go v1.1.7/go.mod h1:KdQUCv79m/52Kvf8AW2vK1V8akMuk1QjK/uOdHXbAo4=
 github.com/jstemmer/go-junit-report v0.0.0-20190106144839-af01ea7f8024/go.mod h1:6v2b51hI/fHJwM22ozAgKL4VKDeJcHhJFhtBdhmNjmU=
+github.com/jstemmer/go-junit-report v0.9.1 h1:6QPYqodiu3GuPL+7mfx+NwDdp2eTkp9IfEUpgAwUN0o=
+github.com/jstemmer/go-junit-report v0.9.1/go.mod h1:Brl9GWCQeLvo8nXZwPNNblvFj/XSXhF0NWZEnDohbsk=
 github.com/jtolds/gls v4.20.0+incompatible/go.mod h1:QJZ7F/aHp+rZTRtaJ1ow/lLfFfVYBRgL+9YlvaHOwJU=
 github.com/juju/ansiterm v0.0.0-20180109212912-720a0952cc2a h1:FaWFmfWdAUKbSCtOU2QjDaorUexogfaMgbipgYATUMU=
 github.com/juju/ansiterm v0.0.0-20180109212912-720a0952cc2a/go.mod h1:UJSiEoRfvx3hP73CvoARgeLjaIOjybY9vj8PUPPFGeU=

diff --git a/tools.go b/tools.go
@@ -5,6 +5,7 @@
 package tools
 
 import (
+	_ "github.com/jstemmer/go-junit-report"
 	_ "github.com/vektra/mockery"
 	_ "k8s.io/code-generator/cmd/client-gen"
 )