Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-rollouts): update rollout cluster role #2844

Closed
wants to merge 1 commit into from

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Jul 24, 2024

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

update rollout cluster role for enable progressively scaleDown deployment. for this feature: argoproj/argo-rollouts#3111

@yyzxw yyzxw requested review from jmeridth and yu-croco as code owners July 24, 2024 09:30
@yyzxw yyzxw changed the title feat: update rollout cluster role fix(argo-rollouts): update rollout cluster role Jul 24, 2024
@yu-croco
Copy link
Collaborator

Hi @yyzxw , thank you for your PR.
As discussed in #2795 , we are waiting for new version that contains this permission fix in upstream. We will handle this when Renovate makes PR.
e.g.) #2794

@yu-croco yu-croco added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Jul 25, 2024
@yu-croco
Copy link
Collaborator

We handled in #2880 (review), so let us close this PR.
Again thank you for your PR.

@yu-croco yu-croco closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-rollouts awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants